Skip to content

docs: remove deprecated accessibilityStates prop#871

Merged
eriveltonelias merged 3 commits into
react-navigation:mainfrom
Naturalclar:removeDeprecatedProp
Oct 6, 2020
Merged

docs: remove deprecated accessibilityStates prop#871
eriveltonelias merged 3 commits into
react-navigation:mainfrom
Naturalclar:removeDeprecatedProp

Conversation

@Naturalclar
Copy link
Copy Markdown
Contributor

@Naturalclar Naturalclar commented Oct 6, 2020

READ ME PLEASE!

Changed accessibilityStates prop to accessibilityState, as accessibilityStates prop is no longer being used in react-native

ref: facebook/react-native#26168

Thanks for opening a PR!

The docs cover several versions of `react-navigation`, and in some cases there are several files (for version 1, version 2 and etc.) that all describe a single page of the docs (eg. "Getting Started").

Please make sure that the edit you're making in `docs/file-you-edited.md` is also included in the file for the correct version, eg. `/versioned_docs/version-3.x/file-you-edited.md` for version 3. If such file doesn't exist, please create it. :+1:

I've looked at version-3.x docs and the changed content did not exist in the older docs.

@netlify
Copy link
Copy Markdown

netlify Bot commented Oct 6, 2020

Deploy preview for react-navigation-docs ready!

Built with commit 89d8694

https://deploy-preview-871--react-navigation-docs.netlify.app

@netlify
Copy link
Copy Markdown

netlify Bot commented Oct 6, 2020

Deploy preview for react-navigation-docs ready!

Built with commit c915d83

https://deploy-preview-871--react-navigation-docs.netlify.app

eriveltonelias
eriveltonelias approved these changes Oct 6, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@eriveltonelias eriveltonelias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@eriveltonelias eriveltonelias merged commit b45f408 into react-navigation:main Oct 6, 2020
@Naturalclar Naturalclar deleted the removeDeprecatedProp branch October 7, 2020 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eriveltonelias eriveltonelias eriveltonelias approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Naturalclar @eriveltonelias